feat(k0s): disable internal update probe for k0s #3066
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| assertCommands(t, dr.Commands, | ||
| []interface{}{ | ||
| regexp.MustCompile(fmt.Sprintf(`k0s install controller .* --kubelet-extra-args --node-ip=.* --hostname-override=%s .*--data-dir /var/lib/embedded-cluster/k0s`, regexp.QuoteMeta(expectedHostname))), | ||
| regexp.MustCompile(fmt.Sprintf(`k0s install controller .* --kubelet-extra-args --node-ip=.* --hostname-override=%s .*--data-dir /var/lib/embedded-cluster/k0s .*--disable-components konnectivity-server,update-prober`, regexp.QuoteMeta(expectedHostname))), |
There was a problem hiding this comment.
Bug: Regex Mismatch Causes Test Failures
The test regex hardcodes update-prober as always disabled in the k0s install command's disabled components list. The actual command, however, conditionally disables update-prober based on k0s version support. This mismatch causes test failures when the component isn't disabled in the generated command.
emosbaugh
approved these changes
Oct 16, 2025
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables the upstream fix from - k0sproject/k0s#6326
This has been backported for 1.33 and seems like it might also be backported for 1.32 - k0sproject/k0s#6524
Blocking this until latest 1.33 is released and we update it on our end.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/129365/pass-the-disable-k0s-update-probe-flag-once-1-33-backport-version-available
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
Yes need to update - replicatedhq/replicated-docs#3537